Arcs appear broken in FPS demo.

Avatar
peter hastings
  • updated
  • Fixed

Image 337

I'm running the FPS HUD demo in Unity 2020.3.2, and it appears that Arcs don't render when the initial angle is greater than the final angle.
Also, if an arc isn't centered at the origin it appears to have a slightly larger radius than intended.

Reporting a bug? please specify Unity version:
2020.3.2
Reporting a bug? please specify Shapes version:
3.2.1
Reporting a bug? please specify Render Pipeline:
Built-in render pipeline
Pinned replies
Avatar
1
Freya Holmér creator
  • Answer
  • Fixed

this has now been fixed in 3.2.2. here are the changes if you want a quick fix before it's released. (line numbers on the left and filename at the top)

Replies 7
Avatar
0
peter hastings

If it helps, I've changed FpsController.cs to run some tests:

...which ends up looking like this:

Avatar
0
peter hastings

Oh, and a few more tests. I hope I'm understanding the API correctly?
I'm using Draw.Arc() to make a series of circles which should all be tangential to each other, but not all of them come out that way. (I'm hijacking the FpsController.cs demo file again here...)

Visually, we get this result. But I'm pretty sure these circles should all be tangential.

Avatar
0
Freya Holmér creator

yeah something definitely broke, looking into this now!

Avatar
1
Freya Holmér creator
  • Answer
  • Fixed

this has now been fixed in 3.2.2. here are the changes if you want a quick fix before it's released. (line numbers on the left and filename at the top)

Avatar
0
peter hastings

Thanks for the quick reply! Version 3.2.2 definitely improves things. But I think there's still a problem with arcs getting clipped in the demo scene:

Avatar
1
Freya Holmér creator

I swear I double checked this before I uploaded ;-;
another patch coming soon I guess!

Avatar
0
Freya Holmér creator

this has now been fixed (again/fully, for reals this time~) in 3.2.3