"NewShapesRenderFeature" cripples performances in URP, and is not essential

Avatar
Gael Flores
  • updated
  • Fixed

Hi, this renderer feature gets added automatically when the editor gets loaded.

Image 509

Even after I remove it comes back.

Removing it will improve perfomances significantly in urp for VR.

Even empty renderer feature will lower the performance, so it's not because of that particular renderer feature.

So if a renderer isn't absolutely crucial, I'll remove it to gain more FPS.

Please don't automatically add it back when I remove it (especially when Shapes runs fine without it)

Reporting a bug? please specify Unity version:
2020.3.16
Reporting a bug? please specify Shapes version:
4.1.0
Reporting a bug? please specify Render Pipeline:
URP
Pinned replies
Avatar
0
Freya Holmér creator
  • Answer
  • Fixed

these are no longer auto-added as of 4.1.1. In addition, the settings window now has a sanity checker where you can see which renderer data supports IM drawing in shapes or not, and tell you how to fix it

Replies 2
Avatar
0
Freya Holmér creator
  • Under Review

does unticking the render feature fix the performance issues?

it's currently required for immediate mode drawing, but if you're not using IM then it's optional.

that being said, if you want to remove it from being automatically added, this is done in ShapesImportState.cs in the EnsureShapesPassExistsInTheUrpRenderer function, in case you want to edit the code to prevent it from happening

I've considered revamping the way this works in the future, but hopefully this helps in the meantime

Avatar
0
Freya Holmér creator
  • Answer
  • Fixed

these are no longer auto-added as of 4.1.1. In addition, the settings window now has a sanity checker where you can see which renderer data supports IM drawing in shapes or not, and tell you how to fix it